fix: resolve all failing tests across utility modules#205
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - date-utils: round (not floor) hours-to-days in formatRelative - string-utils: implement truncate word-boundary logic and fix wordCount - task-manager: implement remove, update, and sortBy methods - validator: accept long TLDs in isEmail and ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. All 60 tests now pass (0 failures), with no previously-passing tests broken and no new dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")instead of returningInfinity.src/date-utils.ts—formatRelativenow usesMath.round(wasMath.floor) for the hours-to-days conversion, fixing the off-by-one (36h → "2 days ago").src/string-utils.ts— implementedtruncate(ellipsis counts towardmaxLength, word-boundary truncation, returns unchanged when within limit, handles strings shorter than the ellipsis) and fixedwordCountto collapse consecutive whitespace.src/task-manager.ts— implemented/completedremove,update, andsortBy(by priority high→medium→low, and bycreatedAtoldest-first).src/validator.ts—isEmailnow accepts long TLDs (e.g.user@example.museum);isUrlnow accepts URLs with a port (e.g.http://localhost:3000) via theURLconstructor.Testing
bun test→ 60 pass, 0 fail.Notes / assumptions
formatRelative(a date ~23.5h ago can render as "24 hours ago"); this predates the change, is not covered by any test, and was left out of scope per the "fix only what the tests require" constraint.